On 03/03/2015 04:09 PM, Jan Cholasta wrote:
> Dne 3.3.2015 v 16:04 Tomas Babej napsal(a):
>>
>> On 03/03/2015 04:01 PM, Martin Kosek wrote:
>>> On 03/03/2015 03:49 PM, Jan Cholasta wrote:
>>>> Hi,
>>>>
>>>> the attached patches provide an attempt to fix
>>>> <https://fedorahosted.org/freeipa/ticket/3090>.
>>>>
>>>> Patch 401 serves as an example and modifies ipa-advise to use its own
>>>> API
>>>> instance for Advice plugins.
>>>>
>>>> Honza
>>> Thanks. At least patches 399 and 400 look reasonable short for 4.2.
>>>
>>> So with these patches, could we also get rid of
>>> temporary_ldap2_connection we
>>> have in ipa-replica-install? Petr3 may have other examples he met in
>>> the past...
> 
> I think we can. Shall I prepare a patch?

If it is reasonable simple, I would go for it. It would be another selling
point for your patches.

> 
>>>
>>> Martin
>>
>> 401 seems reasonable enough to me too, the bulk of the code is mostly
>> just moving the code around and renaming variables.
> 
> Right.
> 
>>
>> Plus we have a very extensive (100%) coverage for the advise tool, so I
>> wouldn't exclude it from the patchset.
> 
> +1

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to