On 5.3.2015 14:50, Petr Spacek wrote:
> Hello,
> 
> please review this patch set. It should be applied on top of your previous
> p11helper patch set.
> 
> Thank you!

Reviewer requested reworded version of the error message, here it is.

-- 
Petr^2 Spacek
From dd05ce3026b30874355ca3a441d7ccc51c65f287 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Wed, 4 Mar 2015 20:35:17 +0100
Subject: [PATCH] p11helper: clarify error message

https://fedorahosted.org/freeipa/ticket/4657
---
 ipapython/ipap11helper/p11helper.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ipapython/ipap11helper/p11helper.c b/ipapython/ipap11helper/p11helper.c
index 3874c4dc1a2fcf0f58d6b75d6379fa36c4075f86..eff49f5908412eb7b6e4c163710843e64e3bb69b 100644
--- a/ipapython/ipap11helper/p11helper.c
+++ b/ipapython/ipap11helper/p11helper.c
@@ -237,7 +237,9 @@ int check_return_value(CK_RV rv, const char *message) {
             (&errmsg, "Error at %s: 0x%x\n", message, (unsigned int) rv)
             == -1) {
             PyErr_SetString(ipap11helperError,
-                            "DOUBLE ERROR: Creating the error message caused an error");
+                            "An error occured during error message generation. "
+                            "Please report this problem. Developers will use "
+                            "a crystal ball to find out the root cause.");
             return 0;
         }
         if (errmsg != NULL) {
-- 
2.1.0

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to