On (05/03/15 16:20), Petr Vobornik wrote: >On 03/05/2015 11:23 AM, Lukas Slebodnik wrote: >>On (05/03/15 08:54), Petr Vobornik wrote: >>>On 02/27/2015 09:50 PM, Lukas Slebodnik wrote: >>>>ehlo, >>>> >>>>Please review attached patches and fix freeipa in fedora 22 ASAP. >>>> >>>>I think the most critical is 1st patch >>>> >>>>sh$ git grep "SSSDConfig" | grep import >>>>install/tools/ipa-upgradeconfig:import SSSDConfig >>>>ipa-client/ipa-install/ipa-client-automount:import SSSDConfig >>>>ipa-client/ipa-install/ipa-client-install: import SSSDConfig >>>> >>>>BTW package python-sssdconfig is provides since sssd-1.10.0alpha1 >>>>(2013-04-02) >>>>but it was not explicitely required. >>>> >>>>The latest python3 changes in sssd (fedora 22) is just a result of negligent >>>>packaging of freeipa. >>>> >>>>LS >>>> >>> >>>Fedora 22 was amended. >>> >>>Patch 1: ACK >>> >>>Patch 2: ACK >>> >>>Patch3: >>>the package name is libsss_nss_idmap-python not python-libsss_nss_idmap >>>which already is required in adtrust package >>In sssd upstream we decided to rename package libsss_nss_idmap-python to >>python-libsss_nss_idmap according to new rpm python guidelines. >>The python3 version has alredy correct name. >> >>We will rename package in downstream with next major release (1.13). >>Of course it we will add "Provides: libsss_nss_idmap-python". >> >>We can push 3rd patch later or I can update 3rd patch. >>What do you prefer? >> >>Than you very much for review. >> >>LS >> > >Patch 3 should be updated to not forget the remaining change in ipa-python >package. > >It then should be updated downstream and master when 1.13 is released in >Fedora, or in master sooner if SSSD 1.13 becomes the minimal version required >by master.
Fixed. BTW Why ther is a pylint comment for some sssd modules I did not kave any pylint problems after removing comment. ipalib/plugins/trust.py:32: import pysss_murmur #pylint: disable=F0401 ipalib/plugins/trust.py:38: import pysss_nss_idmap #pylint: disable=F0401 And why are these modules optional (try except) ipalib/plugins/trust.py-31-try: ipalib/plugins/trust.py:32: import pysss_murmur #pylint: disable=F0401 ipalib/plugins/trust.py-33- _murmur_installed = True ipalib/plugins/trust.py-34-except Exception, e: ipalib/plugins/trust.py-35- _murmur_installed = False ipalib/plugins/trust.py-36- ipalib/plugins/trust.py-37-try: ipalib/plugins/trust.py:38: import pysss_nss_idmap #pylint: disable=F0401 ipalib/plugins/trust.py-39- _nss_idmap_installed = True ipalib/plugins/trust.py-40-except Exception, e: ipalib/plugins/trust.py-41- _nss_idmap_installed = False LS
>From 41523fd6ab9ea95644cac1a6cd20386a620a1df5 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Fri, 27 Feb 2015 20:40:06 +0100 Subject: [PATCH 1/3] SPEC: Explicitly requires python-sssdconfig Resolves: https://fedorahosted.org/freeipa/ticket/4929 --- freeipa.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/freeipa.spec.in b/freeipa.spec.in index b186d9fdff31118ea4d929f024f4dc16a75b1d0b..9513f45c6c933a1109390393cb90d68e8c697dc7 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -122,6 +122,7 @@ Requires: mod_auth_kerb >= 5.4-16 Requires: mod_nss >= 1.0.8-26 Requires: python-ldap >= 2.4.15 Requires: python-krbV +Requires: python-sssdconfig Requires: acl Requires: python-pyasn1 Requires: memcached @@ -228,6 +229,7 @@ Requires: wget Requires: libcurl >= 7.21.7-2 Requires: xmlrpc-c >= 1.27.4 Requires: sssd >= 1.12.3 +Requires: python-sssdconfig Requires: certmonger >= 0.76.8 Requires: nss-tools Requires: bind-utils -- 2.3.1
>From 69c4f4bfc911990dc7ec650c2958aaf716c53ac5 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Fri, 27 Feb 2015 20:43:38 +0100 Subject: [PATCH 2/3] SPEC: Require python2 version of sssd bindings Python modules pysss and pysss_murmur was part of package sssd-common. Fedora 22 tries to get rid of python2 and therefore these modules were extracted from package sssd-common to separate packages python-sss and python-sss-murmur and python3 version of packages python3-sss python3-sss-murmur git grep "pysss" | grep import ipalib/plugins/trust.py: import pysss_murmur #pylint: disable=F0401 ipaserver/dcerpc.py:import pysss ipaserver/dcerpc.py is pacakged in freeipa-server-trust-ad palib/plugins/trust.py is packaged in freeipa-python Resolves: https://fedorahosted.org/freeipa/ticket/4929 --- freeipa.spec.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/freeipa.spec.in b/freeipa.spec.in index 9513f45c6c933a1109390393cb90d68e8c697dc7..7a1ff8b50ef1b462ad14fb2328149c3c2ed2fb38 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -195,6 +195,9 @@ Requires: samba >= %{samba_version} Requires: samba-winbind Requires: libsss_idmap Requires: libsss_nss_idmap-python +%if (0%{?fedora} >= 22) +Requires: python-sss +%endif # We use alternatives to divert winbind_krb5_locator.so plugin to libkrb5 # on the installes where server-trust-ad subpackage is installed because # IPA AD trusts cannot be used at the same time with the locator plugin @@ -288,6 +291,9 @@ Requires: python-qrcode-core >= 5.0.0 Requires: python-pyasn1 Requires: python-dateutil Requires: python-yubico +%if (0%{?fedora} >= 22) +Requires: python-sss-murmur +%endif Requires: wget Requires: dbus-python -- 2.3.1
>From e906786e5c66cbd8f85ea251aec806d25723ec0b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Fri, 27 Feb 2015 21:02:51 +0100 Subject: [PATCH 3/3] SPEC: Add missing requires for python-libsss_nss_idmap git grep "pysss_nss_idmap" | grep import ipalib/plugins/trust.py: import pysss_nss_idmap #pylint: disable=F0401 ipaserver/dcerpc.py:import pysss_nss_idmap ipaserver/dcerpc.py is packaged in freeipa-server-trust-ad palib/plugins/trust.py is packaged in freeipa-python Resolves: https://fedorahosted.org/freeipa/ticket/4929 --- freeipa.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/freeipa.spec.in b/freeipa.spec.in index 7a1ff8b50ef1b462ad14fb2328149c3c2ed2fb38..2344f6a435f36a87dcd454ad2fb4a191d316ef80 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -294,6 +294,7 @@ Requires: python-yubico %if (0%{?fedora} >= 22) Requires: python-sss-murmur %endif +Requires: libsss_nss_idmap-python Requires: wget Requires: dbus-python -- 2.3.1
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code