On 04/08/2015 03:18 PM, Jan Cholasta wrote:
the attached patches remove IPASimpleLDAPObject from ipaldap.
As a result, the one and only IPA LDAP API is the LDAPClient API.
This is definitely an improvement :)
0408: ACK (woohoo!)
I quite like the new __init__ signature, and the context manager
Can you add a comment for the `object.__setattr__(self, '_conn', None)`
in _disconnect? It's a real eyesore.
0412: Can _force_schema_updates be set already in __init__?
0416: I think you should show off the `with` statement support here.
0417: ... and here
0422: ACK, and good riddance
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code