On Thu, 2015-04-23 at 14:12 +0200, Petr Vobornik wrote: > On 04/23/2015 12:24 PM, Petr Vobornik wrote: > > If unbind was called when disconnected it raised: > > AttributeError: 'NoneType' object has no attribute 'unbind_s' > > > > AttributeError is not a public error and therefore it prevented > > ldap2.destroy_connection() to be called multiple times. > > > > fixes: > > https://fedorahosted.org/freeipa/ticket/4991 > > > > Note: this issue also prevented rpcserver.change_password from > > working. > > Therefore I think that there might have been an error in recent > > ipaldap > > refactoring and if #4991 was not run on master then there might > > have > > been other issue, which probably have been fixed by the > > refactoring. > > > > After discussion with Honza, the approach was changed. > > Also I've added patch which removes unnecessary incorrect code which > revealed the regression. > > Additional testing shows that these patches actually don't fix the > original issue of #4991. See > https://fedorahosted.org/freeipa/ticket/4991#comment:4
0823 - ACK 0824 - ACK Nathaniel -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
