Dne 20.4.2015 v 11:59 Petr Vobornik napsal(a):
On 04/20/2015 09:51 AM, Jan Cholasta wrote:
Dne 9.4.2015 v 13:56 Petr Vobornik napsal(a):
On 04/08/2015 10:21 AM, Jan Cholasta wrote:
4) The processing of memberof should be done even when memberofindirect
is not requested, otherwise its value will depend on whether
memberofindirect was requested or not.


True, but it's the same behavior as before. Could be changed in other
patch.

OK. Should we file a ticket?

AFAIK, memberof and memberofindirect are requested always together atm.
Do we have a use case for this change?

It's a bug. Use case is when someone requests memberof only, they must get direct memberof values only.

In any case, I've opened a ticket
about more finer control of fetching members (as was discussed
previously in triage and dev mtgs), it might be part of it.

https://fedorahosted.org/freeipa/ticket/4995

OK.





5) I would prefer if all membership processing
(.convert_attribute_members() and .get_indirect_members()) was done
in a
single LDAPObject method.

Now, as before, get_indirect_members is called before post callbacks and
convert_attribute_members after. If it should be combined, it should be
done separately.

OK, but at least move get_indirect_members to LDAPObject.


Moved

Thanks, ACK.

Pushed to master: 4364ac08c538e3a4253804f523707092b34c2ed2

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to