On Tue, 12 May 2015, Petr Vobornik wrote:
On 05/12/2015 11:22 AM, Alexander Bokovoy wrote:
On Tue, 12 May 2015, Martin Babinsky wrote:
%attr(644,root,root) %{_unitdir}/ipa-ods-exporter.service
+%attr(644,root,root) %{etc_systemd_dir}/httpd.service
There is a minor issue: a lack of

Requires: /etc/systemd/system

which is needed because of /etc/systemd/system directory owned by a
different package. We require systemd-units which is provided by systemd
package as well so it is sort of mitigated by that but it would
good to be explicit in the require. And yes, you can require the
directory because systemd provides it:

$ rpm -q --whatprovides /etc/systemd/system
systemd-219-13.fc22.x86_64

Otherwise, ACK.

thank for review Alexander, attaching updated patch.
ACK

Pushed to master: 9a1a409d63e30dcb939b672d352fc4aa7ba690fe
We also need a tmpfiles config changes because otherwise
/var/run/httpd/krbcache does not exist.

Patch attached.
--
/ Alexander Bokovoy
From b13986cf0815c6e90d313fb8a4ab5f739901222a Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <aboko...@redhat.com>
Date: Tue, 12 May 2015 16:45:01 +0000
Subject: [PATCH] Make sure new httpd kerberos cache directory is created

---
 init/systemd/ipa.conf.tmpfiles | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/systemd/ipa.conf.tmpfiles b/init/systemd/ipa.conf.tmpfiles
index b4503cc..276a1dc 100644
--- a/init/systemd/ipa.conf.tmpfiles
+++ b/init/systemd/ipa.conf.tmpfiles
@@ -1,3 +1,4 @@
 d /var/run/ipa_memcached 0700 apache apache
 d /var/run/ipa 0700 root root
 d /var/run/httpd/clientcaches 0700 apache apache
+d /var/run/httpd/krbcache 0700 apache apache
-- 
2.4.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to