On Wed, 13 May 2015, Anthony Messina wrote:
On Wednesday, May 13, 2015 01:28:44 PM Martin Babinsky wrote:
On 05/12/2015 06:47 PM, Alexander Bokovoy wrote:
> On Tue, 12 May 2015, Petr Vobornik wrote:
>> On 05/12/2015 11:22 AM, Alexander Bokovoy wrote:
>>> On Tue, 12 May 2015, Martin Babinsky wrote:
>>>>>> %attr(644,root,root) %{_unitdir}/ipa-ods-exporter.service
>>>>>> +%attr(644,root,root) %{etc_systemd_dir}/httpd.service
>>>>>
>>>>> There is a minor issue: a lack of
>>>>>
>>>>> Requires: /etc/systemd/system
>>>>>
>>>>> which is needed because of /etc/systemd/system directory owned by a
>>>>> different package. We require systemd-units which is provided by
>>>>> systemd
>>>>> package as well so it is sort of mitigated by that but it would
>>>>> good to be explicit in the require. And yes, you can require the
>>>>> directory because systemd provides it:
>>>>>
>>>>> $ rpm -q --whatprovides /etc/systemd/system
>>>>> systemd-219-13.fc22.x86_64
>>>>>
>>>>> Otherwise, ACK.
>>>>
>>>> thank for review Alexander, attaching updated patch.
>>>
>>> ACK
>>
>> Pushed to master: 9a1a409d63e30dcb939b672d352fc4aa7ba690fe
>
> We also need a tmpfiles config changes because otherwise
> /var/run/httpd/krbcache does not exist.
>
> Patch attached.

ACK

I'm not sure it matters, but mod_auth_kerb already sets up
/var/run/httpd/krbcache via /lib/tmpfiles.d/httpd-krbcache.conf:
d /var/run/httpd/krbcache 0700 apache apache
We don't use mod_auth_kerb in Fedora 22 anymore, and mod_auth_gssapi
doesn't bring the same configuration in, so installing git master will
fail to operate due to missing directory.

--
/ Alexander Bokovoy

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to