On 05/19/2015 07:22 PM, Petr Vobornik wrote:
On 05/19/2015 05:34 PM, thierry bordaz wrote:
On 05/15/2015 05:38 PM, David Kupka wrote:
On 05/15/2015 12:34 PM, Petr Vobornik wrote:
On 05/15/2015 10:59 AM, Petr Vobornik wrote:
Stage User Web UI is actually just the last four patches(847-850).

I expect that patch 848 - deleter dialog needs some adjustments (was
discussed offline).

The rest are prerequisites, namely:
- update of patternfly
- update navigation code to support multiple entities under one entity
tree (it broke a "memory feature/bug" of the navigation)
- support for "facet tabs" in sidebar

Attaching new version of 847-1. The old version did not apply because I
had also a new version of topology plugin UI (will be send later today)
in my git tree.
thanks for patches. Please note that I tested only functionality
because I'm not familiar with WebUI internals.

I tried your patch set together with Thierry's ULC patches and found
following issues:

1) Missing all but 'Delete' actions in single stage user view.
'Enable', 'Disable', 'Unlock', 'Add OTP Token' and 'Rebuild auto
membership ' actions are not relevant here.

Fixed in patch 850-1.

2) Missing 'Restore' action in single preserve user view.

Will be added later.

3) When deleting preserved user there are options to preserve or
permanently delete user. This doesn't make sense and don't work.
Preserved user is always permanently removed.

Fixed in patch  new patch 853

4) Action 'Delete' in single user view deletes the user without asking
whether to 'preserve' or 'delete permanently'.

Will be fixed later.

*) I would prefer if the choice between 'preserve' and 'permanently
delete' in delete dialog was done by directly clicking button not
switching 'mode' radio button and then clicking 'delete'.

Otherwise everything seems to work well.

Petr this is looking very nice and easy to use. I am not an expert of
the console, so I run the demo use case and was able to complete all the
steps (being a stage adminitrator).
The only remark I have is that when activating a stage user, the message
mentions 'users' be the CLI actually supports only one user.
Are you sure you want to activate selected users

You can select multiple users and activate them in UI. It will call
stageuser_activate for each user.

Except that this is perfect for me.

Thanks a lot

In this new patch set there are also new icons.

Instead of http://fontawesome.io/icon/plus/
- restore action has http://fontawesome.io/icon/heart/
- activate action has http://fontawesome.io/icon/check/

There are also new icons which indicates user state(in page header) in
stage user details page.
- stage users have http://fontawesome.io/icon/wrench/
- preserved users have http://fontawesome.io/icon/trash-o/

Was agreed offline that just functionality review was OK for this patch set. Green light for the push was given on IRC.

Pushed to master:
* a4c0f780b727cc92a9b6fa21e42906a80f4f7d42 webui: update patternfly to v1.1.4 * 69bc4f4955c8ee0bdbeea5ca340a003c128e9a58 webui: rename IPA.user_* to IPA.user.* * c352616ac9fbb1685adcbe8834143b24f6e8b5d4 webui: declare search command options in search facet * de374a0d3a1147a650b63bb5c267a857fba015dd webui: register construction spec based on existing spec * ae62bd6914dcdd24667dc1ff149413d9a7adc017 webui: entity facets in facet registry * 2be8eeb04f08cb51a25651794a2f356a2a7b499e webui: entity menu items navigate to main entity facet * 6bcb90ef36f7400e9f1eb197421134d5650c39fe webui: prefer entity fallback in menu item select * 8f6013952061099fff4ec9b8784fc1ee91828c4e webui: navigation: do not remember selected childs of menu item * 6a2b486e500b62abe7ef14e4f34c945726f3256b webui: navigation: unique names on entity facet menu items * 17aafc36b4c94cffa8427c8f4b2aef2292bba40d webui: metadata validator min and max value overrides * 3c2a8b408ec1af284af0ebe218832f3fab85c008 webui: custom facet groups in a facet
* 435f9331c633296d72160de1e25bbdc77a81c75e webui: facet groups widget
* 8d8b56d135ad05fbfee35fb88618ce8c5498fd68 webui: allow to replace facet tabs with sidebar * cae2df274a9ba92a4fc8db0259811c1755c648e6 webui: allow to hide facet tabs or sidebar * bf7ee6eeecd71ffeb4740a440fd237a6fac4793f webui: facet policies for all facets
* 14525598f97f57d165682247ef7f5cf63f810be5 webui: stageuser plugin
* 64e87d5e34f646f0de5b0b310ccaf02cbb119a2b webui: extend user deleter dialog with --permanent and --preserve options * 52647285f6d286c079090b5bff21f5e423076897 webui: update stageuser/user pages based on action in diffrent user search page * 99d282d38d0c847ebb544140edd49d6572f06cb0 webui: stageusers, display page elements based on user state * 7ddcff3ef71a1d4254d291bdab99075f2cd8f205 webui: prefer search facet's deleter dialog
Petr Vobornik

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to