On 22/05/15 17:40, Gabe Alford wrote:
On Fri, May 22, 2015 at 9:01 AM, Martin Basti <mba...@redhat.com <mailto:mba...@redhat.com>> wrote:


    On 22/05/15 16:08, Gabe Alford wrote:
    Hello,

    This should fix https://fedorahosted.org/freeipa/ticket/3584, and
    as requested in the ticket, this should also fix
    https://fedorahosted.org/freeipa/ticket/2284

    Thanks,

    Gabe


    Thank you!

    IMO your first part of fix only mask issue, not solving it.

    This could be way, but I did not test it.

                out_encoding = getattr(outfile, 'encoding', None)
                if out_encoding is None:
                    out_encoding = 'utf-8'
                print >> outfile, unicode(string).encode(out_encoding)


I'm confused and maybe missing something here. If I run `ipa help dns | bad_command`, shouldn't the command fail with only the following?
-bash: bad: command not found


    Can you split this patch into 2 separate patches for each ticket
    please?


Done

    Martin^2

-- Martin Basti


Thank you!
ACK and ACK.

--
Martin Basti

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to