On 05/22/2015 04:20 PM, Petr Vobornik wrote:
On 05/21/2015 12:55 PM, thierry bordaz wrote:
On 05/20/2015 05:40 PM, Ludwig Krispenz wrote:
please find new versions of patches 0003 and 0005 for  the topology
plugin.

the ds plugin patch includes
- changes to match domain level patch
- remove trailing white spaces
- use proper oids for topology schema

the install patch
- has the  70topology.ldif removed

Hello Ludwig,

I failed to do 'git am patch-0003', it returned a strange "Patch format
detection failed.".
However I was able to do 'git apply' and to review it.

I focus on the points discussed during previous reviews.
The patch is looking good to me. ACK

Patch 0003 pushed to master: 25bf0c6e78dca62e7fa11cd654ed0d8675408176

Note that installation of replica with domain level 1 suffers from: https://fedorahosted.org/freeipa/ticket/5035



Patch 0005 looks good to me if we squash there attached patch(typo fixes).

I think that both 0003 and 0005 could be pushed. But I'll do it when
testing with Domain Level patch is successful.

Patch 0005

ACK

Pushed to master: 4bcc2546d59041f0d09960d6f9d44ca68bd424e1


patch 0006 will be replaced with the one I'm working on.


thanks
thierry

--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to