On 05/22/2015 10:03 AM, Petr Spacek wrote: > On 18.5.2015 17:31, Petr Spacek wrote: > > Hello, > > > > This patch is unrelated to metaDB but it should be merged before alpha, too. > > > > Thank you for review! > > > > Support unknown record types (RFC 3597). > > > > Fallback to generic LDAP attribute "UnknownRecord;TYP256" if attempt to > > add specific attribute like "URIRecord" failed with > > LDAP_OBJECT_CLASS_VIOLATION > > and always delete both attributes like "URIRecord" and > > "UnknownRecord;TYPE256". > > > > https://fedorahosted.org/bind-dyndb-ldap/ticket/157 > > Fixed version is attached. Version 1 could dereference NULL pointers in second > iteration of while loops. > I did only formal review. Didn't find any issues.
ACK. Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
