On 06/23/2015 08:58 PM, Nathaniel McCallum wrote:


On Jun 23, 2015, at 2:55 PM, Simo Sorce <s...@redhat.com> wrote:

On Tue, 2015-06-23 at 18:51 +0200, Christian Heimes wrote:
+WSGIImportScript /usr/lib/python2.7/site-packages/kdcproxy/__init__.py \
+  process-group=kdcproxy application-group=kdcproxy
+WSGIScriptAlias /KdcProxy /usr/lib/python2.7/site-packages/kdcproxy/__init__.py

I find sticking an application in __init__.py a bit questionable, but
that's in kdcproxy and not your code.
Nathaniel, can you chnage that in future ? Or maybe we can do it now ?

We should really have something like /usr/sbin/wsgi_kscproxy.py
or /usr/libexec/kdcproxy/kdcproxy.py or similar, not something snook
into a __init__.py file down there.

Everything else looks ok to me.

I think it is a valid upstream question. If we change that upstream, we can 
update FreeIPA.

Alright, let’s ride this patch all the way to ACK-town.

Nathaniel


Pushed to master: 495da412f155603c02907187c21dd4511281df2c
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to