On 06/30/2015 04:50 PM, Ludwig Krispenz wrote:
new patch attached

On 06/30/2015 03:37 PM, thierry bordaz wrote:
On 06/30/2015 12:07 PM, Ludwig Krispenz wrote:
added verification for issue reported in ticket 5088 and sanity checks requested in review for patch 0014


Hello,

The fix looks good except those sanity settings:

  * In ipa_topo_post_del, tsegm needs to be NULL initialized
  * In ipa_topo_check_segment_is_valid or ipa_topo_pre_add, I think
    *errtxt should be initialized to NULL

thanks
thierry


ACK

thanks
thierry
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to