Hi,

Dne 2.7.2015 v 11:15 Fraser Tweedale napsal(a):
Attached patches fix a couple of important gaps in certprofile
plugin:

- Add --out option to export Dogtag profile data to file
   https://fedorahosted.org/freeipa/ticket/5091

- Add --file option to update existing profile in Dogtag
   https://fedorahosted.org/freeipa/ticket/5093


Just a couple nitpicks:

+    takes_options = LDAPUpdate.takes_options + (
+        File('file?',
+            label=_('File containing profile configuration'),
+            cli_name='file',
+            flags=('virtual_attribute',),
+        ),
+    )

1) Don't set cli_name if it's the same as name.

2) The virtual_attribute flag is meaningless in Commands.

3) Add "include='cli'" to denote that the option is specific to CLI (applies to --out as well).

Honza

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to