On 17.7.2015 13:00, Martin Basti wrote:
> On 15/07/15 18:13, Petr Spacek wrote:
>> On 15.7.2015 17:39, Martin Basti wrote:
>>> On 15/07/15 17:38, Petr Spacek wrote:
>>>> On 15.7.2015 17:33, Martin Basti wrote:
>>>>> On 15/07/15 16:03, Martin Basti wrote:
>>>>>> On 15/07/15 15:39, Petr Vobornik wrote:
>>>>>>> On 07/15/2015 02:42 PM, Martin Basti wrote:
>>>>>>>> Patch attached.
>>>>>>>>
>>>>>>>>        https://fedorahosted.org/freeipa/ticket/4934
>>>>>>>>        https://fedorahosted.org/freeipa/ticket/5055
>>>>>>>>
>>>>>>> Why are you adding RP, APL, IPSEC, DHCID, HIP, SPF records? Is there a
>>>>>>> plan
>>>>>>> to use them? Can't we just not use unsupported records in LDAPSearch'?
>>>>>>> (which would fix #5055)
>>>>>> I had discussion with Petr2, and we decided to do it this way, because
>>>>>> these
>>>>>> records are valid.
>>>>>>
>>>>>> Removing unsupported records from search changes the behavior of the DNS
>>>>>> commands. Now IPA shows even unsupported records which cannot be
>>>>>> modified by
>>>>>> API. AFAIK we want to keep this behavior.
>>>>>>
>>>>> Updated patch attached.
>>>>>
>>>>> I forgot to remove DNSKEY from object class definition.
>>>> Are you 100 % sure that it will not break on upgrade? Please double-check
>>>> that
>>>> with Thierry.
>>>>
>>> IT was my change before we decided that DNSKEY should not be there, it is 
>>> not
>>> in git repo.
>> I see, okay.
>>
> Updated patch attached.

The intent described in the commit message LGTM.

Unfortunately I do not have time for further review, please find somebody else 
:-)

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to