On 14/07/15 12:19, Martin Babinsky wrote:
On 03/30/2015 12:38 PM, Martin Babinsky wrote:
On 03/26/2015 01:14 PM, Martin Kosek wrote:
On 03/25/2015 04:18 PM, Jan Cholasta wrote:

Dne 25.3.2015 v 15:26 Martin Babinsky napsal(a):
The attached patch related to

Please make sure <https://fedorahosted.org/freeipa/ticket/3048> stays

It is certainly not a final solution, more of an initial "hack" of
just to gather some suggestions, since I am not even sure if this is
right thing to do.

The reporter from bugzilla suggests to enable debugging of ALL commands called through ipautil.run(), but I think that fixing all cca 157 found
usages of run() is too much work with a quite small benefit.

Anyway I would welcome some opinions about this: should the external
commands really inherit the debug settings of ipa-* utilities, and if
so, is the method showed in this patch the right way to do it?

I am not a fan of this method, ipautil.run does not know anything
about the
command it runs and I think it should stay that way.

I would prefer to have an ipautil.run wrapper with debug flag using
debugging option for each command where we need to conditionally enable
debugging. Or just add the debugging option unconditionally to every
where it could be useful.

+1, I do not like this change to ipautil.run either. It should be sole
responsibility of the caller to specify the right combinations of
including debug option, where applicable.

Attaching updated patch.

Reviving this patch from the dead. Attaching rebased version for master branch and ipa-4-1.

Works for me, ACK

Martin Basti

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to