On 07/24/2015 05:34 PM, Martin Basti wrote:
> On 24/07/15 16:52, Tomas Babej wrote:
>> On 07/24/2015 03:40 PM, Fraser Tweedale wrote:
>>> The attached patch adds --out option to user-show for saving user's
>>> certificate(s) to file.
>>> Thanks,
>>> Fraser
>> I hate to nitpick here, but is "out" really a descriptive option name
>> here? I'd prefer something more explicit, like '--save-cert-to', or
>> maybe even have this operation implemented as a separate command
>> altogether.
>> Tomas
> This keyword was already used with several commands. For consistency
> might be better to have it the same.

True. I see this options is being used in the following commands:

 - cert-show
 - vault-retrieve
 - host-show
 - service-show
 - user-show (proposed)

While the first two seem to be an acceptable fit for an option called
--out, as they mainly deal with cert/secret, using the '--out' for the
latter three is a poor decision imho.

I agree the consistency is important, I'm just not happy to see this
spread further.


Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to