On Fri, 2015-07-24 at 12:20 +0200, Christian Heimes wrote: > Hello, > > while I was working on https://fedorahosted.org/freeipa/ticket/5142 and > patch 019, I noticed the variable names rsa_public_key and > rsa_private_key in vault.py. load_pem_public_key() can load and return > other key formats (DSA, ECDSA), too. Does vault mean to support the > other algorithms? > > In case vault should support any kind of asymmetric cipher, I'd like to > change the variable names. It's confusing. Otherwise we should add a > check for RSA and prevent DSA and ECDSA keys. > > Christian >
We certainly want to support ECDSA keys eventually, so I'd rename the vars. Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
