On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote:
> Hi,
> 
> Dne 31.7.2015 v 12:46 Simo Sorce napsal(a):
> > I've been carrying these patches in my tree for a while, I think it is
> > time to put them in master as they stand on their own.
> >
> > Simo.
> 
> Patch 530: ACK
> 
> Patch 531: ACK
> 
> Patch 532:
> 
> The methods should be static methods:
> 
>      @staticmethod
>      def setOption(name, value):
>      ...

Care to explain why ?
@staticmethod is not used anywhere else in that file.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to