On 08/06/2015 10:37 AM, Tomas Babej wrote: > > > On 08/05/2015 08:40 PM, Alexander Bokovoy wrote: >> Hi, >> >> attached patch fixes a bug >> https://bugzilla.redhat.com/show_bug.cgi?id=1249455 >> >> details are in the commit message. >> >> >> > > Looks good to me, generates bindings strings as described in the BZ. > > Just a readability nitpick, can we get rid of the binding_template > lambda abstraction and use something like this? > > binding_template=u'%s:%s[%s]' > return [binding_template % (t, remote_host, o) for t in transports > for o in options] > > or just plain: > > return [u'%s:%s[%s]' % (t, remote_host, o) for t in transports for o > in options] > > instead of: > > binding_template=lambda x,y,z: u'%s:%s[%s]' % (x, y, z) > return [binding_template(t, remote_host, o) for t in transports for > o in options] > > Tomas >
Before pushing, please use https://fedorahosted.org/freeipa/ticket/5183 as reference. I just cloned it. Thanks, Martin -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code