On Thu, 2015-08-06 at 07:21 +0200, Jan Cholasta wrote:
> Dne 5.8.2015 v 17:24 Simo Sorce napsal(a):
> > On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote:
> >> Hi,
> >> Dne 31.7.2015 v 12:46 Simo Sorce napsal(a):
> >>> I've been carrying these patches in my tree for a while, I think it is
> >>> time to put them in master as they stand on their own.
> >>> Simo.
> >> Patch 530: ACK
> >> Patch 531: ACK
> >> Patch 532:
> >> The methods should be static methods:
> >> @staticmethod
> >> def setOption(name, value):
> >> ...
> > Care to explain why ?
> > @staticmethod is not used anywhere else in that file.
> Because the methods do not use any instance or class state. They will of
> course work fine even if they are normal methods, but making them static
> methods is cleaner.
Ok, I embedded the change in my tree.
I am working on some fixes to the replica promotion patchset with
Ludwig, so I will respin all of the patches at once later on.
Simo Sorce * Red Hat, Inc * New York
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code