On 08/07/2015 04:51 PM, Tomas Babej wrote:

On 08/07/2015 04:22 PM, Martin Babinsky wrote:
Short term fix for https://fedorahosted.org/freeipa/ticket/4826


couple of minor issues:

1.) Please create a separate constant for the WARNING section, now this
segment is copy-pasted at three different places in the plugin.

2.) It would be nice to fix the broken indentation in the help texts for
ipa idrange-add/mod whlie poking at that part of the code.

How should these sections be indented (especially the warning parts)?

3.) 'ipa help idranges' does not produce any info, it error message
needs to suggest 'ipa help idrange'

Otherwise looks and works good.


Martin^3 Babinsky

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to