On 10.8.2015 17:43, Milan Kubík wrote:
Hi all,

this patch fixes problem described in the ticket [1]
that caused the test run to fail completely at every other or so run.
I took the liberty to fix most of the pep8 issues while I was at it.

Thanks to Jan Cholasta for help with identifying this one.

IMO this would be more robust:

    t = None
    try:
        ...
    finally:
        del t
        nss.nss_shutdown()

By assigning a value to the variable at the beginning you make sure that the del statement will not fail.

Honza

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to