On 08/11/2015 10:06 AM, thierry bordaz wrote:
No, it didn't occur to me to test activation of nonexistent user, I can
On 08/04/2015 01:37 PM, Lenka Doudova wrote:
Dne 30.7.2015 v 16:10 Martin Basti napsal(a):
Attaching new patch - (hopefully) fixed the errors from the old one +
few test cases were added.
On 30/07/15 16:09, Martin Basti wrote:
On 29/07/15 16:10, Martin Basti wrote:
Ahoj, v patchi mas este uvedene svoje stare meno, mala by si v gite
nastavit redhat email
On 29/07/15 15:29, Lenka Doudova wrote:
thanks a lot for the comments, will work on it tomorrow.
Dne 29.7.2015 v 15:27 Martin Basti napsal(a):
On 27/07/15 16:47, Lenka Doudova wrote:
I'm attaching a patch with automated tests for stageuser plugin
(https://fedorahosted.org/freeipa/ticket/3813). The user plugin
test is affected as well (one class was added).
The tests seem a bit of a mess even to myself, but what with
the way freeipa behaves I didn't know how else to implement
them, but I'm eager to learn how to do it in a nicer way, if
someone has a better idea.
I just applied patches:
1) Please remove whitespace errors
$ git am
Applying: Automated test for stageuser plugin
""" Tracker class for staged user LDAP object
StageUserTracker object stores information about the user.
u'krbprincipalexpiration', u'usercertificate', u'dn',
u'street', u'postalcode', u'facsimiletelephonenumber',
u'cn', u'ipauniqueid', u'objectclass', u'description',
warning: squelched 50 whitespace errors
warning: 55 lines add whitespace errors.
Please use new shorter format of license header
3) can you fix some of the most serious PEP8 errors
$ git show -U0 | pep8 --diff | wc -l
if options != None:
Please use "options *is not* None"
For consistency it should be u'random'
if key == 'random':
self.attrs[u'randompassword'] = fuzzy_string
Otherwise it looks good
And also fix this please
************* Module ipatests.test_xmlrpc.test_stageuser_plugin
[E0102(function-redefined), user2] function already defined line 44)
Sorry for spam, you can safely ignore this. :)
This is a very impressive work and test framework. I have not
understood all the details of the implementation so I just focus on
the reading the tests body.
The patch is looking great to me and I have really few minors comments.
* About non existing stage user, you may try to activate a non
existing one. Is it what TestStagedUser.test_activate does ?
The values are checked - in the test itself, using 'create_from_staged'
I first copy attributes of stage user object to a new active user object
(just object, not the ipa user itself) and in 'check_activate' I verify
that values of ipa user correspond with those taken from staged user
* In test_create_attr, I can see that user6 is activated. How is
checked that the specified values are preserved ? (sorry my python
skill is still very low)
Yes, all the options are implemented using parametrized fixture
'stageduser2' + 'options_ok' list, tests are performed by
'test_create_attr' method. These tests also contain activation check
(users can be activated and values are preserved).
* Many testcases
are about creating a stage user with various attributes
(initial,shell, homedir...). I found uid/gid, are the others
check_delete just checks the result of 'user-del' command (it just says
that a certain user has been deleted). But after that, there is a
verification that the user is no longer in _active_ container performed
by running 'user-show' command with 'not found' as expected result.
* In TestActive.test_delete_preserve, does check_delete check the
active container or the stageuser container ?
If you mean whether there is a check like running 'user-show' command
and expecting 'not found', no, there is not. I haven't thought about it.
* Does test_delete_preserved checks that the deleted entry has been
permanently removed ?
I'd say that partly - it just verifies if membership can be added to a
preserved user (expects failure of such attempt).
It does not check whether a user with thus successfully assigned
membership preserves it after 'user-undel' (but that is part of
TestPreserved.test_reactivate_preserved - the 'check_attr_preservation'
method verifies that reactivated user is member of 'ipausers' group only).
* Is test_preserved_membership the test case for
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code