On 08/26/2015 11:19 AM, Michael Šimáček wrote:


On 2015-08-26 10:43, Jan Cholasta wrote:
On 26.8.2015 10:37, Martin Basti wrote:
Master branch is broken, this patch fixes it.

Patch attached.

This is not a pylint error, but an actual bug.


Yes, commit e46d9236d19f714b67fdf2865f19146c3016f46d (yesterday evening) added another reference to krbV after my patch for migration from krbV was reviewed. This patch looks ok to me, I'd just change the commit message (to "Remove leftover krbV reference" or something like that).

Thanks,
Michael

Fixed.

updated patch attached.
From a5733f8ff5623ef10b4c740226fd5834fab1a6db Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 26 Aug 2015 10:34:25 +0200
Subject: [PATCH] Fix: Remove leftover krbV reference

---
 ipalib/plugins/vault.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipalib/plugins/vault.py b/ipalib/plugins/vault.py
index 483da5f0e9d2674c8d856543214d4baba7876a04..d06b63d68a27ee0522f636504188852570033a42 100644
--- a/ipalib/plugins/vault.py
+++ b/ipalib/plugins/vault.py
@@ -989,7 +989,7 @@ class vault_mod(PKQuery, Local):
         else:
             backend = self.api.Backend.rpcclient
         if not backend.isconnected():
-            backend.connect(ccache=krbV.default_context().default_ccache())
+            backend.connect()
 
         # determine the vault type based on parameters specified
         if vault_type:
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to