On 09/01/2015 08:57 AM, Martin Basti wrote:


On 08/31/2015 06:05 PM, Martin Kosek wrote:
On 08/31/2015 02:52 PM, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/5265

Patch attached.

Should I remove also message class "DNSSECWarning" which is not used now, or
just keep it there because ti has already registered error code?

Martin^2


Just for the record, I added more pointers to why we think DNSSEC is now more stabilized to the ticket - this is an important information that should warrant
removal of the warning messages.

Thank you.

Rebased patches for master attached.
From 6a1f1ffa76cd89972ebda19a55bf7d0abe750341 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Mon, 31 Aug 2015 13:51:02 +0200
Subject: [PATCH] DNSSEC: remove "DNSSEC is experimental" warnings

https://fedorahosted.org/freeipa/ticket/5265
---
 ipalib/plugins/dns.py    | 18 ------------------
 ipaserver/install/dns.py |  2 --
 2 files changed, 20 deletions(-)

diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index 512a653c3cc8ee641debec0d20f58e17eff08266..a3d562edb186682a872073e6c83a416b6a4cbc09 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -2624,22 +2624,6 @@ class dnszone(DNSZoneBase):
             messages.add_message(options.get('version', VERSION_WITHOUT_CAPABILITIES),
                                  result, messages.ForwardersWarning())
 
-    def _warning_dnssec_experimental(self, result, *keys, **options):
-        # add warning when user use option --dnssec
-        if 'idnssecinlinesigning' in options:
-            if options['idnssecinlinesigning'] is True:
-                messages.add_message(options['version'], result,
-                    messages.DNSSECWarning(
-                    additional_info=_("Visit 'http://www.freeipa.org/page/Releases/4.1.0#DNSSEC_Support'.")
-                ))
-            else:
-                messages.add_message(options['version'], result,
-                    messages.DNSSECWarning(
-                    additional_info=_("If you encounter any problems please "
-                    "report them and restart 'named' service on affected IPA "
-                    "server.")
-                ))
-
     def _warning_name_server_option(self, result, context, **options):
         if getattr(context, 'show_warning_nameserver_option', False):
             messages.add_message(
@@ -2735,7 +2719,6 @@ class dnszone_add(DNSZoneBase_add):
         result = super(dnszone_add, self).execute(*keys, **options)
         self._warning_deprecated_option(result, **options)
         self.obj._warning_forwarding(result, **options)
-        self.obj._warning_dnssec_experimental(result, *keys, **options)
         self.obj._warning_name_server_option(result, context, **options)
         self.obj._warning_fw_zone_is_not_effective(result, *keys, **options)
         return result
@@ -2826,7 +2809,6 @@ class dnszone_mod(DNSZoneBase_mod):
     def execute(self, *keys, **options):
         result = super(dnszone_mod, self).execute(*keys, **options)
         self.obj._warning_forwarding(result, **options)
-        self.obj._warning_dnssec_experimental(result, *keys, **options)
         self.obj._warning_name_server_option(result, context, **options)
         return result
 
diff --git a/ipaserver/install/dns.py b/ipaserver/install/dns.py
index 9430d189978b0984b0b71d7d754516a4135053fb..538e99fbe01a34cee627f1cebd938be19777c134 100644
--- a/ipaserver/install/dns.py
+++ b/ipaserver/install/dns.py
@@ -126,8 +126,6 @@ def install_check(standalone, replica, options, hostname):
         print "NOTE: DNSSEC zone signing is not enabled by default"
         print ""
         if options.dnssec_master:
-            print "DNSSEC support is experimental!"
-            print ""
             print "Plan carefully, replacing DNSSEC key master is not recommended"
             print ""
         print ""
-- 
2.4.3

From 9d4795de7094c18a62d354950b5af44077687c51 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Mon, 31 Aug 2015 13:51:02 +0200
Subject: [PATCH] DNSSEC: remove "DNSSEC is experimental" warnings

https://fedorahosted.org/freeipa/ticket/5265
---
 ipalib/plugins/dns.py    | 18 ------------------
 ipaserver/install/dns.py |  2 --
 2 files changed, 20 deletions(-)

diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index 81c7e06532f4bb1fa73831c365d61247ea063b26..be0639b6ada1b95364dc53a42f8a762e0671fe1a 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -2627,22 +2627,6 @@ class dnszone(DNSZoneBase):
             messages.add_message(options.get('version', VERSION_WITHOUT_CAPABILITIES),
                                  result, messages.ForwardersWarning())
 
-    def _warning_dnssec_experimental(self, result, *keys, **options):
-        # add warning when user use option --dnssec
-        if 'idnssecinlinesigning' in options:
-            if options['idnssecinlinesigning'] is True:
-                messages.add_message(options['version'], result,
-                    messages.DNSSECWarning(
-                    additional_info=_("Visit 'http://www.freeipa.org/page/Releases/4.1.0#DNSSEC_Support'.")
-                ))
-            else:
-                messages.add_message(options['version'], result,
-                    messages.DNSSECWarning(
-                    additional_info=_("If you encounter any problems please "
-                    "report them and restart 'named' service on affected IPA "
-                    "server.")
-                ))
-
     def _warning_name_server_option(self, result, context, **options):
         if getattr(context, 'show_warning_nameserver_option', False):
             messages.add_message(
@@ -2738,7 +2722,6 @@ class dnszone_add(DNSZoneBase_add):
         result = super(dnszone_add, self).execute(*keys, **options)
         self._warning_deprecated_option(result, **options)
         self.obj._warning_forwarding(result, **options)
-        self.obj._warning_dnssec_experimental(result, *keys, **options)
         self.obj._warning_name_server_option(result, context, **options)
         self.obj._warning_fw_zone_is_not_effective(result, *keys, **options)
         return result
@@ -2829,7 +2812,6 @@ class dnszone_mod(DNSZoneBase_mod):
     def execute(self, *keys, **options):
         result = super(dnszone_mod, self).execute(*keys, **options)
         self.obj._warning_forwarding(result, **options)
-        self.obj._warning_dnssec_experimental(result, *keys, **options)
         self.obj._warning_name_server_option(result, context, **options)
         return result
 
diff --git a/ipaserver/install/dns.py b/ipaserver/install/dns.py
index 1c31f0c6685b2b50859f882b23753d2a0a0ca463..917ed808efe3e7f65182b653627b76328f97a5d0 100644
--- a/ipaserver/install/dns.py
+++ b/ipaserver/install/dns.py
@@ -128,8 +128,6 @@ def install_check(standalone, replica, options, hostname):
         print("NOTE: DNSSEC zone signing is not enabled by default")
         print("")
         if options.dnssec_master:
-            print("DNSSEC support is experimental!")
-            print("")
             print("Plan carefully, replacing DNSSEC key master is not recommended")
             print("")
         print("")
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to