On 09/02/2015 08:40 AM, Jan Cholasta wrote:
On 2.9.2015 08:37, Fraser Tweedale wrote:
On Wed, Sep 02, 2015 at 08:08:09AM +0200, Jan Cholasta wrote:
Hi,

On 2.9.2015 03:16, Fraser Tweedale wrote:
This patch *removes* the --rename option from certprofile-mod.
For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1257163#c6

Instead of just removing it, you could also add:

     DeprecatedParam(
         'rename?',
         label=_("Rename"),
         doc=_("Rename the Certificate Profile object"),
     )

to certprofile_mod.takes_options to make the option available, but
deprecated.

Petr Viktorin suggested that due to a) certprofile being a new
command and b) rename having always been refused, it made sense to
just remove it.

Petr, are you in agreement or is Honza's suggestion the way to go?

FYI I'm fine with just removing the option, this was just a suggestion
in case deprecation was overlooked.


ACK

Pushed to:
master: 86cd47af0245a216324900be39be1a145bf0741b
ipa-4-2: b7386dc98506d66c6cbb1083992ced7792f938bd
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to