On 09/01/2015 04:47 PM, Jan Cholasta wrote:
> Hi,
> the attached patches add some more modernization to our code.
> Honza

481: ACK
482: ACK
483: ACK

You can push these without waiting on the later ones.

To avoid merge conflicts later, perhaps it would be better to have

    if six.PY3:
        unicode = str

at the start of each affected file, instead of scattering changes in the
(I can prepare the patch if you agree)

six.binary_type is named "bytes" since Python 2.6. I think it would be
better to use that, to avoid another change when py2 is dropped.
(I can prepare the patch here, too)

486: ACK

Petr Viktorin

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to