On 09/23/2015 05:01 PM, Martin Basti wrote:

On 09/22/2015 12:10 PM, Jan Cholasta wrote:
On 22.9.2015 10:29, Martin Babinsky wrote:
On 09/16/2015 10:44 AM, Jan Cholasta wrote:
On 16.9.2015 08:11, Jan Cholasta wrote:
On 15.9.2015 07:22, Jan Cholasta wrote:
On 10.8.2015 16:58, Martin Babinsky wrote:
On 08/06/2015 08:22 AM, Jan Cholasta wrote:

the attached patch fixes part of

See also Martin Babinsky's patch 51:


Sorry but NACK, see below:

1.) it seems that passing kwargs to Server components doesn't work as
expected. See these logs (install on fresh F22 VM):



2.) the following code blows up in BaseServers' __init__:

392         if not self.dns.setup_dns:
393             if self.dns.forwarders:
394                 raise RuntimeError(
395                     "You cannot specify a --forwarder option
the "
396                     "--setup-dns option")

I think that the check should be:

392         if not self.setup_dns:
393             if self.dns.forwarders:


IMHO BaseServerDNS class shouldn't have setup_dns knob, that should be
set in the parent class (BaseServer)


3.) Is there any reason why BaseServer doesn't have 'master_password', 'idmax' and 'idstart' knobs? I know that these are then brought in by
the derived Server class, but the check for them is in parent's
__init__() method and it is IMHO a bit confusing

The check should be in Server, fixed.

4.) please add license header to the beginning of
'ipaserver/install/server/common.py' file


Updated patches attached.

Self-NACK, I broke ipa-server-install --uninstall.


ACK to all three patches.


Pushed to:
master: 86edd6abeb9749e159a529b83cfce6443fff4ba5
ipa-4-2: 42d16b02cd153ac89ebd8ae07c98611dc3b6e471

These patches introduced regression.
ipa-replica-install in unattended mode requires to specify -a, -p and -r options.

Attached patch fixes it.

Works for me, ACK.

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to