On 29/09/15 14:56, Oleg Fayans wrote:



On 09/29/2015 06:47 PM, Simo Sorce wrote:
On 29/09/15 11:50, Oleg Fayans wrote:
Hi Simo,

It seems to have resolved the initial issue, but now the build fails due
to lint complaints: https://paste.fedoraproject.org/272714/54174014/

These happens if you do not have custodia installed.
I guess I should make it also a BuildRequires ?

I think so, yes.

Turns out it is already there.

Simo.

Simo.

On 09/29/2015 04:54 PM, Simo Sorce wrote:
On 29/09/15 10:39, Oleg Fayans wrote:
Hi Simo,

Is this [1] the correct link to the repo containing all latest
replica-promotion patches? I tried to build the packages from this
code
and the build failed due to libpdb not having make_pdb_method [2]
I was able to successfully build from the clean upstream tree on the
same machine.


I rebased it on top of current master, let me know if this helps.

Simo.


[1]
https://fedorapeople.org/cgit/simo/public_git/freeipa.git/log/?h=custodia-review





[2] https://paste.fedoraproject.org/272672/53685114/

On 09/29/2015 03:55 PM, Simo Sorce wrote:
On 29/09/15 09:28, Jan Pazdziora wrote:
On Thu, Sep 24, 2015 at 09:10:30AM -0400, Simo Sorce wrote:

I think the problem is that the patch was pushed prematurely.
The option should become unused once the other patches in this
patchset are
applied, that is why that patch was not on top of the list but
rather
down
close to the bottom.

Simo,

could you please add the

    How To Test

steps to http://www.freeipa.org/page/V4/Replica_Promotion?

It would make the functional check of this patchset easier, spelling
out how the workflow is supposed to work.

Done.

HTH,
Simo.











--
Simo Sorce * Red Hat, Inc * New York

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to