Guys,

could you please review this patch again? I'd like to have this fix in the new ipa-tests package for downstream team



On 09/29/2015 09:12 AM, Oleg Fayans wrote:
Hi all,

On 09/23/2015 09:13 AM, Petr Spacek wrote:
On 22.9.2015 10:42, Oleg Fayans wrote:
+++ b/ipatests/test_integration/tasks.py
@@ -58,6 +58,14 @@ def check_arguments_are(slice, instanceof):
          return wrapped
      return wrapper

+def prepare_reverse_zone(host, ip):
+    nums = ip.split('.')[:-1]
+    zone = ".".join(reversed(nums)) + ".in-addr.arpa."
+    host.run_command(["ipa",
+                      "dnszone-add",
+                      zone,
+                      "--name-from-ip=%s" % ip], raiseonerr=False)
+

NACK:
- this will break IPv6-only hosts
- you should use DNSName class or other functions from python-dns for
DNS name
manipulation

I hope this helps.

Thanks, it did :)
Used a ipalib.util get_reverse_zone_default function that does just
that: creates a reverse zone name.




--
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to