Hi,

On 1.10.2015 13:01, Martin Basti wrote:


On 09/30/2015 10:25 AM, Petr Viktorin wrote:
On 09/23/2015 04:46 PM, Petr Viktorin wrote:
On 09/22/2015 02:59 PM, David Kupka wrote:
On 18/09/15 17:00, Petr Viktorin wrote:
Hello,
Here are more patches that bring IPA closer to Python 3 compatibility.




Hi Petr,
thanks for another batch of Python 3 compatibility patches.
Unfortunately I hit a lot of pylint errors. Some of them are false
positives for sure. Could you please look at them, mark the false
positive with "pylint: disable=Exxxx" directive and fix the rest?

http://fpaste.org/270090/92665414/

Thanks.
I'm actually having some trouble running pylint on an f23 machine; have
you seen this error before?

$ ./make-lint
Traceback (most recent call last):
   File "./make-lint", line 280, in <module>
     sys.exit(main())
   File "./make-lint", line 251, in main
     linter.check(files)
   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 747,
in check
     self._do_check(files_or_modules)
   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 869, in
_do_check
     self.check_astroid_module(ast_node, walker, rawcheckers,
tokencheckers)
   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 924, in
check_astroid_module
     tokens = utils.tokenize_module(ast_node)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 137, in
tokenize_module
     with module.stream() as stream:
AttributeError: 'Module' object has no attribute 'stream'


Anyway, I've ran pylint on f21. Updated patches attached.
ping, could someone take a look at the patches?


LGTM

I ran xmlrpc tests, DNSSEC ci tests, backup and restore CI test and
everything works

Patches 713-719: ACK


Patch 720:

You missed:

ipa-client/ipa-install/ipa-client-install:32: from ConfigParser import RawConfigParser


Patches 721-722: ACK


Patch 723:

Why the "NoneType = type(None)" in parameters.py? It is used only at:

ipalib/parameters.py:388: type = NoneType # Ouch, this wont be very useful in the real world!


Patch 724:

The SSHPublicKey class was written with the assumption that "str" means binary data, so unless I'm missing something, you only need to replace "str" with "bytes".


Patch 725: ACK


Honza

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to