Hello,
the patch looks good but pep8 cries:

# pep8 ipaserver/install/server/upgrade.py 
ipaserver/install/server/upgrade.py:53:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:68:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:83:25: E261 at least two spaces before 
inline comment
ipaserver/install/server/upgrade.py:88:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:94:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:96:13: E225 missing whitespace around 
operator
ipaserver/install/server/upgrade.py:109:80: E501 line too long (93 > 79 
characters)
ipaserver/install/server/upgrade.py:111:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:131:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:151:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:172:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:179:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:192:80: E501 line too long (108 > 79 
characters)
ipaserver/install/server/upgrade.py:196:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:217:49: E231 missing whitespace after ','
ipaserver/install/server/upgrade.py:222:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:228:80: E501 line too long (83 > 79 
characters)
ipaserver/install/server/upgrade.py:264:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:277:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:333:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:366:80: E501 line too long (82 > 79 
characters)
ipaserver/install/server/upgrade.py:414:49: E251 unexpected spaces around 
keyword / parameter equals
ipaserver/install/server/upgrade.py:414:51: E251 unexpected spaces around 
keyword / parameter equals
ipaserver/install/server/upgrade.py:441:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:455:56: E127 continuation line 
over-indented for visual indent
ipaserver/install/server/upgrade.py:459:25: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:487:37: E126 continuation line 
over-indented for hanging indent
ipaserver/install/server/upgrade.py:494:17: E126 continuation line 
over-indented for hanging indent
ipaserver/install/server/upgrade.py:503:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:504:25: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:511:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:517:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:538:80: E501 line too long (83 > 79 
characters)
ipaserver/install/server/upgrade.py:539:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:541:80: E501 line too long (82 > 79 
characters)
ipaserver/install/server/upgrade.py:542:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:551:80: E501 line too long (89 > 79 
characters)
ipaserver/install/server/upgrade.py:552:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:554:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:556:80: E501 line too long (86 > 79 
characters)
ipaserver/install/server/upgrade.py:557:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:561:80: E501 line too long (91 > 79 
characters)
ipaserver/install/server/upgrade.py:562:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:577:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:603:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:606:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:611:80: E501 line too long (80 > 79 
characters)
ipaserver/install/server/upgrade.py:616:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:619:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:627:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:640:80: E501 line too long (85 > 79 
characters)
ipaserver/install/server/upgrade.py:643:80: E501 line too long (84 > 79 
characters)
ipaserver/install/server/upgrade.py:644:21: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:652:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:664:80: E501 line too long (84 > 79 
characters)
ipaserver/install/server/upgrade.py:666:17: E126 continuation line 
over-indented for hanging indent
ipaserver/install/server/upgrade.py:672:80: E501 line too long (85 > 79 
characters)
ipaserver/install/server/upgrade.py:675:80: E501 line too long (86 > 79 
characters)
ipaserver/install/server/upgrade.py:676:21: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:679:80: E501 line too long (95 > 79 
characters)
ipaserver/install/server/upgrade.py:681:80: E501 line too long (82 > 79 
characters)
ipaserver/install/server/upgrade.py:684:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:699:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:702:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:707:80: E501 line too long (84 > 79 
characters)
ipaserver/install/server/upgrade.py:714:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:716:80: E501 line too long (80 > 79 
characters)
ipaserver/install/server/upgrade.py:717:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:721:5: E303 too many blank lines (2)
ipaserver/install/server/upgrade.py:724:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:733:80: E501 line too long (84 > 79 
characters)
ipaserver/install/server/upgrade.py:738:80: E501 line too long (86 > 79 
characters)
ipaserver/install/server/upgrade.py:739:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:741:80: E501 line too long (86 > 79 
characters)
ipaserver/install/server/upgrade.py:742:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:746:80: E501 line too long (85 > 79 
characters)
ipaserver/install/server/upgrade.py:747:80: E501 line too long (94 > 79 
characters)
ipaserver/install/server/upgrade.py:754:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:756:80: E501 line too long (89 > 79 
characters)
ipaserver/install/server/upgrade.py:757:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:761:5: E303 too many blank lines (2)
ipaserver/install/server/upgrade.py:761:80: E501 line too long (86 > 79 
characters)
ipaserver/install/server/upgrade.py:764:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:781:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:786:80: E501 line too long (80 > 79 
characters)
ipaserver/install/server/upgrade.py:794:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:798:5: E303 too many blank lines (2)
ipaserver/install/server/upgrade.py:801:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:872:80: E501 line too long (80 > 79 
characters)
ipaserver/install/server/upgrade.py:924:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:940:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:949:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:967:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:968:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:971:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:999:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:1003:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1004:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1007:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1069:19: E222 multiple spaces after operator
ipaserver/install/server/upgrade.py:1288:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:1301:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:1307:17: E225 missing whitespace around 
operator
ipaserver/install/server/upgrade.py:1334:80: E501 line too long (81 > 79 
characters)
ipaserver/install/server/upgrade.py:1339:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1341:17: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1389:13: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1399:21: E128 continuation line 
under-indented for visual indent
ipaserver/install/server/upgrade.py:1400:30: E225 missing whitespace around 
operator
ipaserver/install/server/upgrade.py:1440:80: E501 line too long (80 > 79 
characters)
ipaserver/install/server/upgrade.py:1465:14: E111 indentation is not a multiple 
of four
ipaserver/install/server/upgrade.py:1519:27: E126 continuation line 
over-indented for hanging indent
ipaserver/install/server/upgrade.py:1531:26: E126 continuation line 
over-indented for hanging indent
ipaserver/install/server/upgrade.py:1583:80: E501 line too long (96 > 79 
characters)
ipaserver/install/server/upgrade.py:1601:26: E128 continuation line 
under-indented for visual indent


----- Original Message -----
> From: "Jan Cholasta" <jchol...@redhat.com>
> To: "freeipa-devel" <freeipa-devel@redhat.com>
> Sent: Monday, October 12, 2015 3:11:09 PM
> Subject: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in 
> export_kra_agent_pem
> 
> Hi,
> 
> the attached patch fixes <https://fedorahosted.org/freeipa/ticket/5360>.
> 
> Honza
> 
> --
> Jan Cholasta
> 
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to