On 10/14/2015 09:02 AM, Martin Babinsky wrote:
> This patch fixes a regression which was caused by incorrect refactoring
> of user-del command in commit c6299a8cfde7d4e4bb9a50e3cf6406667cee0a6f
> While the `remove_ipaobject_overrides` function was originally called in
> the execute method, this patch puts it into the pre-callback because:
> 1.) it is called in pre-callback of group-del
> 2.) by putting it into pre-callback the overrides are removed for each
> entry when multiple primary keys are specified (maybe it would be good
> to have a test case for this?)
> 3.) since LDAPDelete does not return any entry attributes (it is a
> delete after all), it is not possible to put it into post-callback
> without hacking either the function itself or LDAPDelete class
> 4.) due to this design you have to call it before execution anyway
> https://fedorahosted.org/freeipa/ticket/5365


Pushed to:
ipa-4-2: bbe7d99086112b047bbcf88fc3d1ddeef72a5368
master: 5484ae014ea991335d2fa2478d94169ad29c0f55

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to