Alright. Let's postpone it to 4.4.

Gabe

On Wed, Oct 14, 2015 at 2:52 AM, Martin Basti <mba...@redhat.com> wrote:

> Sorry, we cannot push this patch because I realize that it breaks API
> compatibility.
>
> The proper fix is add this code to find method (not tested)
>
>     def get_options(self):
>         for option in super(user_find, self).get_options():
>             if option.name == "nsaccountlock":
>                 flags = set(option.flags)
>                 flags.remove("no_option")
>                 option = option.clone(flags=flags)
>             yield option
>
> But I do not like too much this code, we plan to do some ipalib
> refactoring in IPA 4.4, so we can do there bigger changes and solve this
> issue in nicer way.
> If you don't mind, I would postpone this to IPA 4.4, instead of hacking
> the framework
>
> Martin
>
>
> On 13.10.2015 19:12, Gabe Alford wrote:
>
> Updated patch attached.
>
> On Tue, Oct 13, 2015 at 10:59 AM, Martin Basti < <mba...@redhat.com>
> mba...@redhat.com> wrote:
>
>>
>>
>> On 13.10.2015 18:53, Gabe Alford wrote:
>>
>> Thanks Martin,
>>
>> What about adding no_create and no_update flags?
>>
>> Gabe
>>
>> Yes, that may work, also please increment minor version of API and add
>> ticket into commit message (https://fedorahosted.org/freeipa/ticket/5366)
>> <https://fedorahosted.org/freeipa/ticket/5366>
>>
>> Thanks.
>> Martin
>>
>>
>> On Tue, Oct 13, 2015 at 9:54 AM, Martin Basti < <mba...@redhat.com>
>> mba...@redhat.com> wrote:
>>
>>>
>>>
>>> On 09.10.2015 19:17, Gabe Alford wrote:
>>>
>>> Hello,
>>>
>>> This patch enables nsaccountlock in user.py cli. It is very handy to be
>>> able to search and find users with disabled/enabled accounts, etc. That
>>> said, I couldn't find why it was no_option in the first place, so I am not
>>> 100% sure if it breaks something or the reasoning behind no_option.
>>>
>>> Thanks,
>>>
>>> Gabe
>>>
>>>
>>> Hello,
>>>
>>> https://fedorahosted.org/freeipa/ticket/5366
>>>
>>> This patch allows to enable/disable user via user-mod, and we do not
>>> want to do this, so NACK for this patch.
>>> I'm not sure yet how to write it in elegant way.
>>>
>>> Martin.
>>>
>>
>>
>>
>
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to