On 10/15/2015 01:30 PM, Tomas Babej wrote:
> 
> 
> On 10/15/2015 01:24 PM, David Kupka wrote:
>> On 15/10/15 13:02, Tomas Babej wrote:
>>>
>>>
>>> On 10/15/2015 12:33 PM, David Kupka wrote:
>>>> Currently, when there is unhanded exception without any message,
>>>> installer ends with error code but without any error message.
>>>>
>>>> Adding line stating that some error occurred and where are logs located
>>>> should help with debugging.
>>>>
>>>>
>>>>
>>>
>>> The default value for the log_file_name is None, so we probably need to
>>> handle this correctly in case the AdminTool class instance logs to
>>> stderr only.
>>>
>>> Tomas
>>>
>>
>> Thanks for good catch, fixed patch attached.
>> I guess the same is true for command_name but it is used quite
>> extensively it the code so it's probably safe to assume that it will be
>> always set.
>>
> 
> Yes, such assumption is reasonable. Unlike log_file_name, there is no
> use case for command_name being set to None intentionally.
> 
> ACK.
> 
> Tomas
> 

Pushed to master: 5aa118d14905daa8c124be1cee02cfeaf26be3e4

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to