On 16.10.2015 15:43, Milan Kubík wrote:
On 09/30/2015 02:47 PM, Martin Basti wrote:
On 09/24/2015 02:49 PM, Milan Kubík
an update for CA ACL tests!
I, with help from M. Babinsky, managed to find a way how to change
the identity during acceptance cest run, which allows
to test CA ACLs (and perhaps other areas with some form of access
This allowed me to write a test for CA ACLs and certificate
profiles that checks if the ACL/profile is being used and
The first several tests are based on Fraser's blogpost using SMIME
The master and ipa-4-2 branches diverged a bit, so I had to change
two commits when rebasing to ipa-4-2 branch.
Commits should be applied in the order (including rebased patches
I sent in an earlier email):
* 12 - 17
* 18, 13 - 15, 19, 17
patches on top of master:
patches on top of ipa-4-2:
rpm file does not contain test_xmlrpc/data directory, please modify
Code contains to much todo for my taste.
Please do not use filter function, use dict comprehension.
updated patches and the numbering mess somehow curbed. The patches are
rebased on top of current master and ipa-4-2.
0) fixed by 0021
1) docs for tracker extended, added more test cases
I have a few comments:
+# TODO: rewrite these into Tracker instances
+ api.Command.user_add(uid=u'alice', givenname=u'Alice', sn=u'SMIME',
+ unlock_principal_password('alice', 'Change123', 'Secret123')
+ def fin():
+ return u'alice'
I do not like hardcoded password value, as this password is used in many
places in the test, I sugest to use a module variable
+ """ Test to verify that the updated profile is used."""
+ pass # import invalid profile, try to sign, expect fail
IMO something is missing here, a test maybe?
Please remove "# noqa" commets from commits
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code