> One more point:
> 
> +        if domain_level > MIN_DOMAIN_LEVEL:
> +            raise RuntimeError(
> +                UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE.format(
> 
> It is kind of weird that error happens if domain level is greater than some
> minimal value. Better naming is badly needed.
> 

Actually, this is not about naming, MIN_DOMAIN_LEVEL constant should not
be used at all.

The constant can be increased to 2 or 3 in later releases, which will
allow the usage of ipa-replica-prepare even if the domain level of the
IPA domain is 1.

Unlike other issues with this patch, which could be considered cosmetic,
this actually is a real bug in the implementation.

Tomas

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to