On 10/29/2015 11:19 AM, Martin Babinsky wrote:
Petr^2 and Tomas were not happy by the way
https://fedorahosted.org/freeipa/ticket/5175 was handled initially, so
here is a patch that tries to amend some of the issues.




IMHO the original text was good.

Tomas, why is the huge blob thing in exception bad?

Issues with new code/text.

1. it is supported but not for domain level != 0:
self.log.error("Using replica files to set up IPA replicas is not "
+                           "supported."
+            )

2. format() is not needed:
+            self.log.info(
+                "To create a replica, you must promote an existing "
+                "IPA client.".format(domain_level=domain_level)
+            )

3. I don't like that the exception text says 'requires', which might imply something to be done - lower domain level - which is not possible. "allowed only" might be better.


Just changing RuntimeError to InvalidDomainLevelError would be fine with me since the MIN_DOMAIN_LEVEL was already changed to DOMAIN_LEVEL_0.
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to