On 30.10.2015 15:49, Rob Crittenden wrote:
Martin Basti wrote:

On 30.10.2015 14:49, Martin Babinsky wrote:
On 10/30/2015 02:09 PM, Martin Basti wrote:

Patch attached

Hi Martin,

NACK since I'm not a big fan of having (nearly) the same function
defined in multiple modules:

$ git grep -n 'def exit_on_managed_topology'
exit_on_managed_topology(what, hint="topologysegment"):
install/tools/ipa-replica-manage:1386:def exit_on_managed_topology(what):

Otherwise the patch works fine.

I tried to do that, but I could not find any suitable module for that,
and the method do just exit() with proper error message, thus it can be
just copy paste (as ipa-csreplica-manage is full of it).

Some common code can be found in ipaserver/install/replication.py

I prefer not to mess replication.py module with this method, it is just wrapped exit, anything useful.

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to