Tested with today's master, ACK.
 - alich -

----- Original Message -----
> From: "Milan Kubík" <mku...@redhat.com>
> To: freeipa-devel@redhat.com
> Sent: Friday, November 27, 2015 3:40:29 PM
> Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations 
> into standalone package
> 
> On 11/27/2015 03:36 PM, Milan Kubík wrote:
> 
> 
> 
> On 11/27/2015 03:31 PM, Milan Kubík wrote:
> 
> 
> On 11/23/2015 10:43 AM, Lenka Doudova wrote:
> 
> 
> NACK - there's a "typo" in ..../tracker/user_plugin.py, line 17-18:
> 
> def get_user_dn(cn):
> 
> return DN(('cn', cn), api.env.container_user, api.env.basedn)
> 
> 
> should be
> 
> def get_user_dn(uid):
> 
> return DN(('uid', uid), api.env.container_user, api.env.basedn)
> 
> 
> Some tests may fail because of that.
> Lenka
> 
> 
> On 11/20/2015 08:54 PM, Aleš Mareček wrote:
> 
> 
> Looks good. ACK.
> 
> ----- Original Message -----
> 
> 
> From: "Milan Kubík" <mku...@redhat.com>
> To: "freeipa-devel" <freeipa-devel@redhat.com>
> Cc: "Filip Skola" <fsk...@redhat.com> , "Ales Marecek" <amare...@redhat.com>
> Sent: Friday, November 20, 2015 3:44:30 PM
> Subject: [patch 0025] Separated Tracker implementations into standalone
> package
> 
> Fixes https://fedorahosted.org/freeipa/ticket/5467
> Patches attached.
> 
> --
> Milan Kubik
> 
> 
> 
> Fixed the function and moved it into different module.
> Updated patches attached.
> 
> 
> 
> Self nack, some imports missing
> 
> --
> Milan Kubik
> 
> 
> Patches updated.
> 
> --
> Milan Kubik
> 
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to