On 12/03/2015 04:26 PM, Aleš Mareček wrote: > Hello, > > ACK for code > NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py > (this function should be in some more general file) >
What place would you propose? The task.py is not a good place, as this is not really a task. Nevertheless, I'd rather have it moved when an use case outside test_sudo.py actually arises. Right now it would lead to unnecessary cluttering. Tomas -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
