NACK

Patch contains syntax error, missing brace

ipaserver/install/server/replicainstall.py:850: [E0001(syntax-error), ] invalid syntax)

Martin

On 09.12.2015 07:08, Jan Cholasta wrote:
LGTM

On 8.12.2015 17:04, Gabe Alford wrote:
Updated patch attached.

On Tue, Dec 8, 2015 at 8:27 AM, Martin Basti <mba...@redhat.com
<mailto:mba...@redhat.com>> wrote:



    On 08.12.2015 16:26, Gabe Alford wrote:
    Just to confirm:

    if server is installed:
         Let's stop here and not do anything else

    if domain level 0:
         check if client installed and stop here

    Right?
    yes




    On Tue, Dec 8, 2015 at 8:20 AM, Jan Cholasta <jchol...@redhat.com
    <mailto:jchol...@redhat.com>> wrote:

        On 8.12.2015 16:17, Martin Basti wrote:



            On 08.12.2015 16:14, Jan Cholasta wrote:

                On 8.12.2015 16:09, Martin Basti wrote:



                    On 01.12.2015 14:57, Gabe Alford wrote:

                        Sorry guys, I forgot to add a meaningful
                        subject to this message.
                        Ignore the previous thread start.

                        ---------- Forwarded message ----------
                        From: *Gabe Alford* <redhatri...@gmail.com
                        <mailto:redhatri...@gmail.com>
                        <mailto:redhatri...@gmail.com
<mailto:redhatri...@gmail.com>>>
                        Date: Mon, Nov 30, 2015 at 7:31 PM
                        Subject: [PATCH 0065]
                        To: freeipa-devel <freeipa-devel@redhat.com
<mailto:freeipa-devel@redhat.com>
                        <mailto:freeipa-devel@redhat.com
<mailto:freeipa-devel@redhat.com>>>


                        Hello,

                        Patch fix for the following tickets:

https://fedorahosted.org/freeipa/ticket/5022
https://fedorahosted.org/freeipa/ticket/5320

                        Thanks,

                        Gabe



                    ACK


                NACK, you can't install a server over an already
                installed client,
                thus the original check is correct.

            Ahh domain level 0, right, but this check can be added
            before the client
            check.


        Yes.

            With domain level 1, this check should stay there IMO.


        Yes. It should say "IPA server is already configured" rather
        than "IPA replica is already configured", though.

        --
        Jan Cholasta







--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to