On 11.12.2015 15:50, Jan Cholasta wrote: > Hi, > > On 10.12.2015 18:04, Petr Spacek wrote: >> On 9.12.2015 15:30, Petr Spacek wrote: >>> Hello, >>> >>> this patch automates some of sanity checks proposed by Petr Vobornik. >>> >>> 'make review' should be used in root of clean Git tree which has patches >>> under >>> review applied. >>> >>> Magic in review.sh attempts to detect nearest remote branch which can be >>> used >>> as diff base for review. Please see review.sh for further details. >> >> And here is the patch! :-) > > Nice, but I would rather see this in ipatool > (<https://github.com/freeipa/freeipa-tools>). Or is there any obvious benefit > in having this in freeipa itself that I'm missing?
For me the obvious benefit is: git clone git am make review Done. No need to find & learn other tool, no risk of using wrong version of the tool to wrong version of source tree etc. -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code