On 06/11/15 14:04, Oleg Fayans wrote:
Hi Jan,

On 11/06/2015 09:01 AM, Jan Cholasta wrote:
Actually it might be better to keep them, but fix them to expect
ipa-server-certinstall to success.

Done. Updated patch attached.
Also in the patch 0013 I removed a trailing whitespace which caused lint
to complain

Now with domain level 0 the test output looks like this:

[11:40:51]ofayans@vm-076:~]$ ipa-run-tests test_integration/test_caless.py
====================================================================================
test session starts
=====================================================================================

platform linux2 -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
plugins: multihost, sourceorder
collected 88 items

test_integration/test_caless.py
......xx......ss...............xx........ss....................xx......ss...............


===================================================================== 76
passed, 6 skipped, 6 xfailed in 7871.10 seconds
=====================================================================



On 6.11.2015 08:47, Jan Cholasta wrote:
Hi Oleg,

I think you can just remove
TestCertinstall.test_{http,ds}_intermediate_ca, the certificates are
imported correctly in this case and I didn't see anything break.

Honza

On 5.11.2015 20:20, Oleg Fayans wrote:
Patch 0014 updated and passes lint

On 11/05/2015 03:41 PM, Oleg Fayans wrote:
Wait a bit, the patch has problems with pylint: it does not build :)
The updated version (without the setupmaster nonsense) is being tested
now.

On 11/05/2015 08:45 AM, Oleg Fayans wrote:
Hi Jan,

Could you take a look at these, whenever you are free?

On 10/30/2015 02:57 PM, Oleg Fayans wrote:
Hi,

The following patches contain updates to ca-less integration tests.
It's still a proof of concept: 2 tests still fail seemingly due to
the
change in target system logic (marked as xfail with "ask jcholast
comment")

The test output looks like this:

$ ipa-run-tests test_integration/test_caless.py --pdb
====================================================================================






test session starts
=====================================================================================







platform linux2 -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
plugins: multihost, sourceorder
collected 88 items

test_integration/test_caless.py
......xx......ss............sssssssssssssssssss.ssssss.........xx......ssxx.............








====================================================================
53

passed, 29 skipped, 6 xfailed in 5620.17 seconds
=====================================================================


Numerous skips correspond to the tests related to
ipa-replica-prepare
(unsupported under domain level 1)















This body part will be downloaded on demand.

Hello, thanks for updated patches. I'm really sorry it took so long before I got to them. There was change in ipapython.ipautil.run that happened after you sent the patches. Feel free to squash attached patch that fixes it.

Unfortunately I see a lot of test failing with domain-level 0: http://fpaste.org/301657/50275682/

domain-level 1 (domain-level 1: http://fpaste.org/301658/02757191/) seems better. There are 2 failing test that you're probably mentioning in commit message plus one that I think is bug in code rather than bug in tests.
Do you have any proposal for fixing the two failing tests?

One nitpick: Please use mail for notes like "need further consulting ..." rather that commit message. When the patch gets accepted it will still need modification before push just because inappropriate commit message.

Thank you!
--
David Kupka
From 2a6e8f02ecd00da2b86d2f3f9847a86caa35e74d Mon Sep 17 00:00:00 2001
From: David Kupka <dku...@redhat.com>
Date: Wed, 16 Dec 2015 09:12:56 +0100
Subject: [PATCH] Addapt CA less test to new ipapython.ipautil.run

---
 ipatests/test_integration/test_caless.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ipatests/test_integration/test_caless.py b/ipatests/test_integration/test_caless.py
index 4b88ee9da1d5a476f13604f9a833e748a0931111..6cb55a708517062edb1bb950a72d6a66f717432e 100644
--- a/ipatests/test_integration/test_caless.py
+++ b/ipatests/test_integration/test_caless.py
@@ -300,10 +300,10 @@ class CALessBase(IntegrationTest):
 
     @classmethod
     def get_pem(cls, nickname):
-        pem_cert, _stderr, _returncode = ipautil.run(
+        result = ipautil.run(
             ['certutil', '-L', '-d', 'nssdb', '-n', nickname, '-a'],
-            cwd=cls.cert_dir)
-        return pem_cert
+            cwd=cls.cert_dir, capture_output=True)
+        return result.output
 
     def verify_installation(self):
         """Verify CA cert PEM file and LDAP entry created by install
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to