Hi David,

On 12/16/2015 03:35 PM, David Kupka wrote:
> On 06/11/15 14:04, Oleg Fayans wrote:
>> Hi Jan,
>>
>> On 11/06/2015 09:01 AM, Jan Cholasta wrote:
>>> Actually it might be better to keep them, but fix them to expect
>>> ipa-server-certinstall to success.
>>
>> Done. Updated patch attached.
>> Also in the patch 0013 I removed a trailing whitespace which caused lint
>> to complain
>>
>> Now with domain level 0 the test output looks like this:
>>
>> [11:40:51]ofayans@vm-076:~]$ ipa-run-tests
>> test_integration/test_caless.py
>> ====================================================================================
>>
>> test session starts
>> =====================================================================================
>>
>>
>> platform linux2 -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
>> plugins: multihost, sourceorder
>> collected 88 items
>>
>> test_integration/test_caless.py
>> ......xx......ss...............xx........ss....................xx......ss...............
>>
>>
>>
>> ===================================================================== 76
>> passed, 6 skipped, 6 xfailed in 7871.10 seconds
>> =====================================================================
>>
>>
>>>
>>> On 6.11.2015 08:47, Jan Cholasta wrote:
>>>> Hi Oleg,
>>>>
>>>> I think you can just remove
>>>> TestCertinstall.test_{http,ds}_intermediate_ca, the certificates are
>>>> imported correctly in this case and I didn't see anything break.
>>>>
>>>> Honza
>>>>
>>>> On 5.11.2015 20:20, Oleg Fayans wrote:
>>>>> Patch 0014 updated and passes lint
>>>>>
>>>>> On 11/05/2015 03:41 PM, Oleg Fayans wrote:
>>>>>> Wait a bit, the patch has problems with pylint: it does not build :)
>>>>>> The updated version (without the setupmaster nonsense) is being
>>>>>> tested
>>>>>> now.
>>>>>>
>>>>>> On 11/05/2015 08:45 AM, Oleg Fayans wrote:
>>>>>>> Hi Jan,
>>>>>>>
>>>>>>> Could you take a look at these, whenever you are free?
>>>>>>>
>>>>>>> On 10/30/2015 02:57 PM, Oleg Fayans wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> The following patches contain updates to ca-less integration tests.
>>>>>>>> It's still a proof of concept: 2 tests still fail seemingly due to
>>>>>>>> the
>>>>>>>> change in target system logic (marked as xfail with "ask jcholast
>>>>>>>> comment")
>>>>>>>>
>>>>>>>> The test output looks like this:
>>>>>>>>
>>>>>>>> $ ipa-run-tests test_integration/test_caless.py --pdb
>>>>>>>> ====================================================================================
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> test session starts
>>>>>>>> =====================================================================================
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> platform linux2 -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
>>>>>>>> plugins: multihost, sourceorder
>>>>>>>> collected 88 items
>>>>>>>>
>>>>>>>> test_integration/test_caless.py
>>>>>>>> ......xx......ss............sssssssssssssssssss.ssssss.........xx......ssxx.............
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ====================================================================
>>>>>>>>
>>>>>>>> 53
>>>>>>>>
>>>>>>>> passed, 29 skipped, 6 xfailed in 5620.17 seconds
>>>>>>>> =====================================================================
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Numerous skips correspond to the tests related to
>>>>>>>> ipa-replica-prepare
>>>>>>>> (unsupported under domain level 1)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>> This body part will be downloaded on demand.
>>
> Hello, thanks for updated patches. I'm really sorry it took so long
> before I got to them.
> There was change in ipapython.ipautil.run that happened after you sent
> the patches. Feel free to squash attached patch that fixes it.

Already noticed this and made the similar fix.

> 
> Unfortunately I see a lot of test failing with domain-level 0:
> http://fpaste.org/301657/50275682/
> 
> domain-level 1 (domain-level 1: http://fpaste.org/301658/02757191/)
> seems better. There are 2 failing test that you're probably mentioning
> in commit message plus one that I think is bug in code rather than bug
> in tests.
> Do you have any proposal for fixing the two failing tests?

I am working on it right now.

> 
> One nitpick: Please use mail for notes like "need further consulting
> ..." rather that commit message. When the patch gets accepted it will
> still need modification before push just because inappropriate commit
> message.

Good to know, thank you!

> 
> Thank you!

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to