Commit message was updated. Thanks!

On 12/17/2015 02:05 PM, Lukas Slebodnik wrote:
> On (17/12/15 13:53), Oleg Fayans wrote:
>>
>> -- 
>> Oleg Fayans
>> Quality Engineer
>> FreeIPA team
>> RedHat.
> 
>>From ed4630140386c1043e36733eb42ec402cc276bee Mon Sep 17 00:00:00 2001
>> From: Oleg Fayans <ofay...@redhat.com>
>> Date: Thu, 17 Dec 2015 13:50:19 +0100
>> Subject: [PATCH] Enabled automatic creation of reverse zone during master
>> installation
>>
> The commit message does not contain ticket.
> It is also not explained why this change was done.
> Could you update commit message with verbose explanation?
> 
> Proper commit message might prevent removal of this change in future
> based on "git blame"
> 
> LS
> 

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
From dd2bc6535c280c22a6f7c1363fa7e704788d86dd Mon Sep 17 00:00:00 2001
From: Oleg Fayans <ofay...@redhat.com>
Date: Thu, 17 Dec 2015 14:25:39 +0100
Subject: [PATCH] Enabled automatic creation of reverse zone during master
 installation

Without an existing reverse zone replica installation fails being unable to
resolve master's ip. It causes integration tests to fail in the environments
where there is no dns server managing reverse zone for the network.
---
 ipatests/test_integration/tasks.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py
index eb1378ef4ba8b5ec27034c8a0c429fd6114cd0a0..478a331ffee5d04e61a5d42c5fabe05427484b83 100644
--- a/ipatests/test_integration/tasks.py
+++ b/ipatests/test_integration/tasks.py
@@ -271,7 +271,8 @@ def install_master(host, setup_dns=True, setup_kra=False):
         '-r', host.domain.name,
         '-p', host.config.dirman_password,
         '-a', host.config.admin_password,
-        "--domain-level=%i" % host.config.domain_level
+        "--domain-level=%i" % host.config.domain_level,
+        "--auto-reverse"
     ]
 
     if setup_dns:
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to