Hi Martin,

On 12/19/2015 08:02 PM, Martin Basti wrote:
> 
> 
> On 18.12.2015 09:35, Oleg Fayans wrote:
>> Hi Petr,
>>
>> On 12/17/2015 08:19 PM, Petr Spacek wrote:
>>> On 17.12.2015 14:27, Oleg Fayans wrote:
>>>> Commit message was updated. Thanks!
>>>>
>>>> On 12/17/2015 02:05 PM, Lukas Slebodnik wrote:
>>>>> On (17/12/15 13:53), Oleg Fayans wrote:
>>>>>> -- 
>>>>>> Oleg Fayans
>>>>>> Quality Engineer
>>>>>> FreeIPA team
>>>>>> RedHat.
>>>>> >From ed4630140386c1043e36733eb42ec402cc276bee Mon Sep 17 00:00:00
>>>>> 2001
>>>>>> From: Oleg Fayans <ofay...@redhat.com>
>>>>>> Date: Thu, 17 Dec 2015 13:50:19 +0100
>>>>>> Subject: [PATCH] Enabled automatic creation of reverse zone during
>>>>>> master
>>>>>> installation
>>>>>>
>>>>> The commit message does not contain ticket.
>>>>> It is also not explained why this change was done.
>>>>> Could you update commit message with verbose explanation?
>>>>>
>>>>> Proper commit message might prevent removal of this change in future
>>>>> based on "git blame"
>>> Seems reasonable in general but this should not happen in BRQ or
>>> ABCDE labs.
>>> Where do you see the problem?
>>>
>>> Otherwise ACK.
>> The problem occurs in local libvirt-powered VMs. Also it may (or may not
>> - I did not try it yet) be met in Beaker.
>>
>>
> NACK
> 
> ipa-server-install: error: You cannot specify a --auto-reverse option
> without the --setup-dns option

Agreed. Updated patch is attached.

> 

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
From 23e1c88a857d31474af7388fb4fb0549aede7eff Mon Sep 17 00:00:00 2001
From: Oleg Fayans <ofay...@redhat.com>
Date: Mon, 21 Dec 2015 11:22:06 +0100
Subject: [PATCH] Enabled automatic creation of reverse zone during master
 installation

---
 ipatests/test_integration/tasks.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py
index eb1378ef4ba8b5ec27034c8a0c429fd6114cd0a0..4a94edd60e6a8423fb8cbfaf9547cb29720f3699 100644
--- a/ipatests/test_integration/tasks.py
+++ b/ipatests/test_integration/tasks.py
@@ -277,7 +277,8 @@ def install_master(host, setup_dns=True, setup_kra=False):
     if setup_dns:
         args.extend([
             '--setup-dns',
-            '--forwarder', host.config.dns_forwarder
+            '--forwarder', host.config.dns_forwarder,
+            '--auto-reverse'
         ])
 
     host.run_command(args)
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to