On 14.12.2015 14:58, Tomas Babej wrote:

On 12/11/2015 07:19 PM, Martin Basti wrote:

On 10.12.2015 15:18, Martin Basti wrote:
Hello,

patch 0374 fixes the ticket, but I found more issues with directory
permission, I fixed them in 0375

https://fedorahosted.org/freeipa/ticket/5520

Patches attached.
Patches attached.

ACK, works as expected.

Pushed to master: 4272ba40ea909b1f783a6fada5b1eebb6efbdf93
I found issue, there was an extra mkdir instead of chmod, patch pushed under one-liner rule

Pushed to:
master: 403652b5b9cc5e80869019067cbe1424b5c02bd1
ipa-4-3: f3a8ef0601b21fe4ddace08d8fd2b7a821efd658
ipa-4-2: 066ecf466403e4e321253238d28a235c7bcc0cd6

From a6af381e996235ad8712ed6ba7995bb70176d24b Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 22 Dec 2015 16:34:32 +0100
Subject: [PATCH] Fix: replace mkdir with chmod

In original patches, extra mkdir has been added instead of chmod.

https://fedorahosted.org/freeipa/ticket/5520
---
 ipaplatform/base/services.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaplatform/base/services.py b/ipaplatform/base/services.py
index 41b9654c90356fcc3819df0d68cbc2ec77178c4f..2ec84cdb21607cb51df6ad5fcd2ae515898bee44 100644
--- a/ipaplatform/base/services.py
+++ b/ipaplatform/base/services.py
@@ -420,7 +420,7 @@ class SystemdService(PlatformService):
             try:
                 if not ipautil.dir_exists(srv_tgt):
                     os.mkdir(srv_tgt)
-                    os.mkdir(srv_tgt, 0o755)
+                    os.chmod(srv_tgt, 0o755)
                 if os.path.exists(srv_lnk):
                     # Remove old link
                     os.unlink(srv_lnk)
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to